Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updaet to Containerd 1.7.11 #2558

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Dec 9, 2023

Updates go version to 1.20.12 and containerd to 1.7.11 for containerd e2e integration tests.

This updates the CI to mirror steps from the vagrantfile for containerd build (previously the make install and plugin build/install steps were not done in CI, but were done in vagrantfile)

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

Merging #2558 (165339e) into main (6f1db26) will increase coverage by 0.00%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2558   +/-   ##
=======================================
  Coverage   65.88%   65.88%           
=======================================
  Files         133      133           
  Lines       16819    16819           
=======================================
+ Hits        11081    11082    +1     
+ Misses       5738     5737    -1     

Signed-off-by: utam0k <k0ma@utam0k.jp>
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Dec 11, 2023

Hey, would this solve the seemingly random failures of containerd tests we see in CI?

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Dec 12, 2023

Hey, would this solve the seemingly random failures of containerd tests we see in CI?

The cause of them can also be the dbus issue that is opened, due to which the tests might be failing

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jan 2, 2024

Hey @utam0k , There is a minor change needed to make this work, I'll go ahead and fix it here.

@YJDoc2 YJDoc2 changed the title Containerd 1.7.10 Updaet to Containerd 1.7.11 Jan 2, 2024
@YJDoc2 YJDoc2 self-requested a review January 2, 2024 10:07
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jan 2, 2024

@utam0k Going ahead and merging this 👍

@YJDoc2 YJDoc2 merged commit b60889d into youki-dev:main Jan 2, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants