Add new method to instantiate Delete command

[rosds]

We were trying to use youki as a library and notice that the Delete command was missing the new method. It can not be instantiated otherwise. This patch also improves the api consistency with other commands.

[utam0k]

@alfonsoros88 Thanks for your contribution! There are new() because only Create and Start are special, and there are used for Run. youki's commands aren't currently planned to be provided as a library, but what do you plan to use them for?

[codecov-commenter]

Codecov Report

Merging #262 (1b14191) into main (3e242b9) will increase coverage by 34.27%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #262       +/-   ##
===========================================
+ Coverage   39.85%   74.13%   +34.27%     
===========================================
  Files          15       43       +28     
  Lines        1405     6596     +5191     
  Branches      385      385               
===========================================
+ Hits          560     4890     +4330     
- Misses        665     1630      +965     
+ Partials      180       76      -104     

[rosds]

@utam0k sorry for the delay! We were trying to use youki's commands by including it as a library dependency to our project. We thought it would be easier to handle it that way instead of using the youki binary and having to handle the dependency with a build.rs.

For creating containers we are not using the Create command directly, as it is just a wrapper of ContainerBuilder. Unfortunately, for cleaning up, the Delete command seems to be the one containing the logic for removing containers. Instead of copy/pasting the exec function, we thought that we could just use the Delete command directly and for that we needed the new() method.

[utam0k]

@alfonsoros88
I see I understand. However, I don't really want to think about providing anything under src/ as a library. Is there any problem to generate Delete structure directly instead?

Delete {
  contaienr_id,
  force,
}

[rosds]

@utam0k we are trying to use youki in https://github.com/esrlabs/northstar. This project uses its own "kind" of containers, we wanted to add support for OCI containers by using youki underneath.

It is not possible to instantiate Delete in that way because the fields are not public.

[utam0k]

@utam0k we are trying to use youki in https://github.com/esrlabs/northstar. This project uses its own "kind" of containers, we wanted to add support for OCI containers by using youki underneath.

It is not possible to instantiate Delete in that way because the fields are not public.

@alfonsoros88 I understand. Let's provide it. Could you add a comment to the effect that you are providing new() for those who are not using it as youki, but are using youki as a library?

[rosds]

@utam0k sure thing! Do you refer to a commit comment or as a doc comment for the new() method?

[utam0k]

@utam0k sure thing! Do refer to a commit comment or as a doc comment for the new() method?

Please do so in the doc comments.

[utam0k]

Thanks!