[doc] Update doc with cross-rs and musl builds
#2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL, thanks! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2621 +/- ##
=======================================
Coverage 65.88% 65.88%
=======================================
Files 133 133
Lines 16819 16819
=======================================
+ Hits 11081 11082 +1
+ Misses 5738 5737 -1 |
jprendes
commented
Jan 9, 2024
|
|
||
| #### Debian, Ubuntu and related distributions | ||
| ```console | ||
| $ sudo apt-get install \ |
There was a problem hiding this comment.
I'm not sure that we need all these dependencies.
IIUC we don't need neither of libsystemd-dev, libelf-dev, libclang-dev or libssl-dev.
Are they needed by any of the tests?
There was a problem hiding this comment.
Good point. I often forget to update the dependencies. A good way to check is to delete them from there and attempt our CI. When all CI are passed, it means they aren't necessary.
https://github.com/containers/youki/blob/656ccc3f69329c2ed10129e046d0474e6c3dee13/justfile#L153-L160
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the mdbook documentation to take into account the changes introduced in #2536