Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add io priority e2e test #2646

Merged
merged 1 commit into from
Feb 20, 2024
Merged

add io priority e2e test #2646

merged 1 commit into from
Feb 20, 2024

Conversation

lengrongfu
Copy link
Collaborator

Fixes: #2639

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024 •
edited
Loading

Codecov Report

Merging #2646 (10a06f1) into main (701085d) will not change coverage.
Report is 19 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2646   +/-   ##
=======================================
  Coverage   65.40%   65.40%           
=======================================
  Files         133      133           
  Lines       16942    16942           
=======================================
  Hits        11081    11081           
  Misses       5861     5861

@lengrongfu lengrongfu force-pushed the test/io-priority branch 3 times, most recently from 4e27e34 to 72cc081 Compare January 24, 2024 06:17
@lengrongfu
Copy link
Collaborator Author

/retest

utam0k
utam0k reviewed Feb 4, 2024
View reviewed changes
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments.

tests/contest/contest/src/main.rs Outdated Show resolved Hide resolved
tests/contest/runtimetest/src/tests.rs Outdated Show resolved Hide resolved
tests/contest/runtimetest/src/tests.rs Outdated Show resolved Hide resolved
@lengrongfu
Copy link
Collaborator Author

@utam0k @YJDoc2 PLAT

YJDoc2
YJDoc2 requested changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, some minor changes, but overall good work! Thanks 🙏

tests/contest/runtimetest/src/tests.rs Outdated Show resolved Hide resolved
tests/contest/contest/src/tests/io_priority/io_priority_test.rs Outdated Show resolved Hide resolved
tests/contest/runtimetest/src/tests.rs Outdated Show resolved Hide resolved
@lengrongfu lengrongfu force-pushed the test/io-priority branch 2 times, most recently from dbd63cd to 3a31383 Compare February 18, 2024 02:45
YJDoc2
YJDoc2 reviewed Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise ok 👍

tests/contest/runtimetest/src/tests.rs Outdated Show resolved Hide resolved
@lengrongfu
add io priority e2e test
10a06f1 
Signed-off-by: lengrongfu <lenronfu@gmail.com>
YJDoc2
YJDoc2 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks!

@YJDoc2 YJDoc2 merged commit 660a242 into youki-dev:main Feb 20, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k left review comments

@YJDoc2 YJDoc2 YJDoc2 approved these changes

Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add io priority e2e test
4 participants
@lengrongfu @codecov-commenter @utam0k @YJDoc2