Rework cgroup detection #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
reviewed
Sep 5, 2021
|
I have a feeling that when using cgroup v2, the values need to be converted just like crun, is that a problem? |
|
Cpu is converted here, but memory doesn't seem to be converted. I will fix this in another PR... |
Furisto
force-pushed
the
cg-detect
branch
2 times, most recently
from
6ee0831
to
1dbf88d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation assumed that cgroup v1 und cgroup v2 could be used side by side, but resource controllers are either attached to the one or the other. A system supports one of three modes (if it is systemd based):
One can check which filesystems are mounted where in order to determine in which mode the system is (see code comments).