Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed test-threads=1 to coverage CI #2699

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Feb 20, 2024

In #2685 I missed adding the test threads option to the coverage CI, due to which it still occasionally times out and fails. This adds that.

Also added in feature test script for uniformity, even though those are not failing

@YJDoc2 YJDoc2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 20, 2024
@codecov-commenter
Copy link

Codecov Report

Merging #2699 (9097a56) into main (0c068b8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2699   +/-   ##
=======================================
  Coverage   65.40%   65.40%           
=======================================
  Files         133      133           
  Lines       16942    16942           
=======================================
  Hits        11081    11081           
  Misses       5861     5861           

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Feb 20, 2024

@containers/youki-maintainers going ahead and merging this as

  1. the test-threads = 1 concept is already reviewed and approved in other PR
  2. This only changes CI file and a script, both are validated by passing their corresponding CI

@YJDoc2 YJDoc2 merged commit e44ce9e into youki-dev:main Feb 20, 2024
28 checks passed
@YJDoc2 YJDoc2 deleted the fix/minor_ci branch February 20, 2024 16:15
@github-actions github-actions bot mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants