Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linux_cgroups_relative_blkio integration test #2722

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarceloSpessoto
Copy link

implement test_group for linux_cgroups_relative_blkio porting oci validation test, requested in tracking issue #361

Signed-off-by: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
Signed-off-by: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
@MarceloSpessoto
Copy link
Author

The relative_blkio.rs file relies on many functions already implemented in blkio.rs for checking supported features. It would be nice to add a specific module defining those functions to reduce code duplication, but I would like to receive some feedback before proceeding with that.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Merging #2722 (f04e246) into main (762a2e8) will decrease coverage by 0.20%.
Report is 48 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2722      +/-   ##
==========================================
- Coverage   65.40%   65.21%   -0.20%     
==========================================
  Files         133      133              
  Lines       16942    16981      +39     
==========================================
- Hits        11081    11074       -7     
- Misses       5861     5907      +46     

@utam0k
Copy link
Member

utam0k commented Mar 8, 2024

@MarceloSpessoto May I ask you to fix formatting warnings?
https://github.com/containers/youki/actions/runs/8148891111/job/22340999781?pr=2722

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Mar 11, 2024

Hey, I'll try to get to a review for code soon. In the meantime please fix the formatting and other failing CIs (if any) . Thanks :)

Signed-off-by: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Mar 18, 2024

Hey, still need to go over the code here, but :

  1. the test you have added is failing on runc, please check
  2. in the error message there, it simply says failed to read file... , but it should also include the error occurred when reading the file, so we can see why it failed, so that needs change :)

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Apr 1, 2024

@MarceloSpessoto ping!

@MarceloSpessoto
Copy link
Author

Hey @YJDoc2 , I've been a little bit busy recently. But I will tackle it this week.

@MarceloSpessoto MarceloSpessoto force-pushed the relative_blkio branch 2 times, most recently from c1099af to f04e246 Compare April 6, 2024 01:46
@MarceloSpessoto
Copy link
Author

Hey guys, things have got a bit rough for me and I am having little time to contribute to youki recently. I don't think I will be able to deliver it shortly. I will keep an eye on the project and I pretend to come back and complete my job someday, but I can't guarantee it won't take some time.
Feel free to close this PR for now and even unallocate the relative_blkio task from the tracking issue. I will certify to come back more prepared in the future.

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Apr 8, 2024

Hey guys, things have got a bit rough for me and I am having little time to contribute to youki recently. I don't think I will be able to deliver it shortly. I will keep an eye on the project and I pretend to come back and complete my job someday, but I can't guarantee it won't take some time.

Hey @MarceloSpessoto , no worries. I can understand that sometimes things get rough. Take your time, and take care. Thanks for letting us know that you can't work on this, so we can take steps accordingly.

Feel free to close this PR for now and even unallocate the relative_blkio task from the tracking issue. I will certify to come back more prepared in the future.

I'll keep the PR open for now, but unassign you from this task, so someone else can pick it if they wan, and use this PR as a reference.

Also, in future if you are still interested and have time and ability to contribute, you're welcome to drop in and pickup some other task!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants