-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add linux_cgroups_relative_blkio integration test #2722
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
Signed-off-by: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
The relative_blkio.rs file relies on many functions already implemented in blkio.rs for checking supported features. It would be nice to add a specific module defining those functions to reduce code duplication, but I would like to receive some feedback before proceeding with that. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2722 +/- ##
==========================================
- Coverage 65.40% 65.21% -0.20%
==========================================
Files 133 133
Lines 16942 16981 +39
==========================================
- Hits 11081 11074 -7
- Misses 5861 5907 +46 |
@MarceloSpessoto May I ask you to fix formatting warnings? |
Hey, I'll try to get to a review for code soon. In the meantime please fix the formatting and other failing CIs (if any) . Thanks :) |
Signed-off-by: Marcelo Mendes Spessoto Junior <marcelomspessoto@gmail.com>
Hey, still need to go over the code here, but :
|
@MarceloSpessoto ping! |
Hey @YJDoc2 , I've been a little bit busy recently. But I will tackle it this week. |
c1099af
to
f04e246
Compare
Hey guys, things have got a bit rough for me and I am having little time to contribute to youki recently. I don't think I will be able to deliver it shortly. I will keep an eye on the project and I pretend to come back and complete my job someday, but I can't guarantee it won't take some time. |
Hey @MarceloSpessoto , no worries. I can understand that sometimes things get rough. Take your time, and take care. Thanks for letting us know that you can't work on this, so we can take steps accordingly.
I'll keep the PR open for now, but unassign you from this task, so someone else can pick it if they wan, and use this PR as a reference. Also, in future if you are still interested and have time and ability to contribute, you're welcome to drop in and pickup some other task! |
implement test_group for linux_cgroups_relative_blkio porting oci validation test, requested in tracking issue #361