Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust version to 1.77.2 #2779

Merged
merged 1 commit into from
May 2, 2024
Merged

Update rust version to 1.77.2 #2779

merged 1 commit into from
May 2, 2024

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented May 2, 2024

Cross updated its msrv to 1.77.2 in cross-rs/cross@7129d5a , so we need to update ours too, as otherwise CI fails to install cross.

Alternatively we can pin cross version, but this is not a big change, and we would be updating rust version eventually anyways.

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
@YJDoc2 YJDoc2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 2, 2024
@YJDoc2 YJDoc2 requested a review from a team May 2, 2024 07:55
@YJDoc2 YJDoc2 merged commit 568992c into youki-dev:main May 2, 2024
29 of 30 checks passed
@YJDoc2 YJDoc2 deleted the rust-1.77.2 branch May 2, 2024 14:54
@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented May 2, 2024

Thanks @jprendes !

@jprendes
Copy link
Contributor

jprendes commented May 2, 2024

I believe an alternative, if we don't want cross to dictate our MSRV would be to do cargo +stable install cross --git https://github.com/cross-rs/cross.

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented May 2, 2024

I believe an alternative, if we don't want cross to dictate our MSRV would be to do cargo +stable install cross --git https://github.com/cross-rs/cross.

Yes, I had also considered that, but I felt their msrv update was a jump 64->77, and don't think are frequent, so decided to update our msrv. In case we observe it to be much more frequent, I'll take the suggested approach and pin cross version instead.

@github-actions github-actions bot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants