Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cache action from default to Swatinem/rust-cache@v1 #278

Merged
merged 5 commits into from
Sep 7, 2021

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Sep 7, 2021

This reduces CI time : for tests and coverage from 4 mins to 1 min, for integration test from ~7 mins to 5 mins. There is not much improvement in integrations tests, as go builds are not cached, maybe that can improve time even more.
Also as coverage uses nightly, the cache will be flushed daily, so the first PR on each day will have slow coverage report, but after that the cache should persist till end of the day. see https://github.com/marketplace/actions/rust-cache
Hope this will improve CI/CD experience for youki!

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Sep 7, 2021

As this is running for the first time here, it will take longer, but after merging the PRs should have faster workflows, as the cache will work. check my notes in YJDoc2#6
Also in case this doesn't work directly, we may need to add shared key field as stated in https://github.com/marketplace/actions/rust-cache , maybe that will work as expected.

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@utam0k utam0k merged commit d4e1069 into youki-dev:main Sep 7, 2021
@YJDoc2 YJDoc2 deleted the change-cache-action branch September 25, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants