Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename to improve readability #2818

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Rename to improve readability #2818

merged 1 commit into from
Jun 19, 2024

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jun 17, 2024

At the moment, recursive options are the only way to do this. Wouldn't it be easier to understand if the names were more specific?

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 17, 2024
@utam0k
Rename to improve readability
d59ee1c 
Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k utam0k requested a review from a team June 17, 2024 13:12
yihuaf
yihuaf approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: change to MountRecursiveAttr? Optional :)

YJDoc2
YJDoc2 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 This change makes so much sense , thank you 🙏

Given that this changes public enum names and error name, I'm adding breaking change label to this. If you think that is not needed, feel free to remove.

@utam0k
Copy link
Member Author

utam0k commented Jun 19, 2024

Nit: change to MountRecursiveAttr? Optional :)

Thanks for your suggestion. But I think Rdonly and others are obviously MountAttr.

@utam0k utam0k merged commit af804e4 into youki-dev:main Jun 19, 2024
29 checks passed
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Merged
@YJDoc2 YJDoc2 mentioned this pull request Aug 16, 2024
Merged
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YJDoc2 YJDoc2 YJDoc2 approved these changes

@yihuaf yihuaf yihuaf approved these changes

Assignees
No one assigned
Labels
breaking change kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utam0k @yihuaf @YJDoc2