selinux: implemented remaining selinux functions #2850

Gekko0114 · 2024-07-14T15:13:40Z

This is an experimental create. This PR is for selinux crate written in Rust.
In this PR, most of remaining selinux functions are implemented.

ref: #2718 #2800 #2825

Gekko0114 · 2024-07-19T10:35:49Z

@utam0k @YJDoc2
Could you review this PR? I think most of remaining selinux functions are covered in this PR.
Though there are several remaining functions, I am not sure all of them are necessary.

utam0k

I'll still review this PR because the changes are significant. But I've done the first my review.

experiment/selinux/src/selinux.rs

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

Gekko0114 · 2024-07-22T15:08:43Z

Hi @utam0k

Thank you so much for your review. I've fixed or replied to your comments.
Could you take a look when you have time?

experiment/selinux/src/selinux.rs

experiment/selinux/src/selinux_label.rs

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

experiment/selinux/src/selinux.rs

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

Gekko0114 · 2024-07-30T01:46:17Z

Hi @utam0k , @YJDoc2
Thanks for your review. I've updated my PR. Could you take a look?

utam0k · 2024-07-30T12:54:01Z

I'll review it when I have more time to review. But the structure itself seemed very readable 😍

utam0k

~~The structure itself looks good to me +1. May I ask you to add main.rs to show an example of how to use this crate?~~ I was mistaken.

experiment/selinux/src/selinux.rs

utam0k

The structure itself looks good to me +1. May I ask you to add main.rs to show an example of how to use this crate?

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

utam0k · 2024-08-03T06:43:16Z

Is this PR ready for re-reviewing?

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

Gekko0114 · 2024-08-03T07:13:51Z

@utam0k
Yes, I've added main.rs.
Please take a look when you have time :)

utam0k · 2024-08-05T00:44:25Z

@utam0k Yes, I've added main.rs. Please take a look when you have time :)

Awesome! Does cargo run need root permission, right?

root ➜ /workspaces/youki/experiment/selinux (selinux) $ ls -Z test_file.txt 
unconfined_u:object_r:public_content_t:s1 test_file.txt

Gekko0114 · 2024-08-05T14:58:14Z

Does cargo run need root permission, right?

Ah I hadn't tried this as a root on workspace, but seems you're right (I've tried it just now).

Seems that whether main.rs can be executed successfully depends on development environment.
I wrote this code on my ec2 amazon linux because selinux is enabled.
However, on my ec2 linux env, "set_file_label" is failed because of amazon linux's setting (though I executed it as a root user).

YJDoc2 · 2024-08-08T05:57:22Z

Hey @Gekko0114 , do you think adding a vagrant file (or making changes in existing ones) to enable selinux in the vagrant box would be a good/easy idea? That way we can have a common dev env to write and test these things. As you said depending on how selinux is setup on machine, the main file can succeed or fail, I think it is a good idea to have a standard env to test in. wdyt?

Gekko0114 · 2024-08-08T14:34:27Z

@YJDoc2 @utam0k
Agree, I think it is good preparing vagrant file for selinux.
Though I am not very familiar with vagrant, I can work on it.
I will take that work after completing this PR. wdyt?

utam0k · 2024-08-16T12:25:01Z

I will take that work after completing this PR. wdyt?

+1

utam0k

Thanks!

* added selinux functions Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> * not use arc Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> * follow reviewer comment Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> * divided selinux impl into two files Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> * fix Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> * fix Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> * fix Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> * use SELinuxLabel struct Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> * use pointer instead of clone Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> * not loop Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> * add main.rs Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com> --------- Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

YJDoc2 added the kind/experimental `/experimental` label Jul 15, 2024

Gekko0114 force-pushed the selinux branch 12 times, most recently from 474bb5f to 005b243 Compare July 19, 2024 09:23

Gekko0114 changed the title ~~added selinux functions~~ added remaining selinux functions Jul 19, 2024

Gekko0114 changed the title ~~added remaining selinux functions~~ selinux: added remaining selinux functions Jul 19, 2024

Gekko0114 changed the title ~~selinux: added remaining selinux functions~~ selinux: implemented remaining selinux functions Jul 19, 2024

Gekko0114 marked this pull request as ready for review July 19, 2024 10:33

utam0k self-requested a review July 21, 2024 03:49

utam0k requested changes Jul 21, 2024

View reviewed changes

Gekko0114 added 3 commits July 22, 2024 14:10

added selinux functions

3c8d871

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

not use arc

e5952e4

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

follow reviewer comment

d02d4d8

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

Gekko0114 force-pushed the selinux branch from 0008e48 to d02d4d8 Compare July 22, 2024 14:10

divided selinux impl into two files

a22a6be

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

utam0k reviewed Jul 27, 2024

View reviewed changes

Gekko0114 added 2 commits July 28, 2024 14:36

fix

54d8408

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

fix

d534bfe

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

YJDoc2 reviewed Jul 29, 2024

View reviewed changes

experiment/selinux/src/selinux.rs Outdated Show resolved Hide resolved

Gekko0114 added 2 commits July 29, 2024 13:49

fix

5a07279

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

use SELinuxLabel struct

ef12153

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

utam0k approved these changes Aug 1, 2024

View reviewed changes

experiment/selinux/src/selinux.rs Outdated Show resolved Hide resolved

experiment/selinux/src/selinux.rs Show resolved Hide resolved

experiment/selinux/src/selinux.rs Outdated Show resolved Hide resolved

utam0k self-requested a review August 1, 2024 11:54

utam0k requested changes Aug 1, 2024

View reviewed changes

Gekko0114 added 2 commits August 2, 2024 22:52

use pointer instead of clone

2b82887

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

not loop

f0da9cb

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

Gekko0114 force-pushed the selinux branch from d4b48cd to 61aa593 Compare August 3, 2024 07:10

add main.rs

6e4fbc7

Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>

Gekko0114 force-pushed the selinux branch from 61aa593 to 6e4fbc7 Compare August 3, 2024 07:10

utam0k approved these changes Aug 16, 2024

View reviewed changes

utam0k merged commit c7d5992 into youki-dev:main Aug 16, 2024
28 checks passed

github-actions bot mentioned this pull request Aug 16, 2024

Release for v0.4.0 #2791

Merged

Gekko0114 deleted the selinux branch August 17, 2024 14:57

github-actions bot mentioned this pull request Aug 23, 2024

Release for v0.4.0 #2891

Closed

Gekko0114 mentioned this pull request Sep 1, 2024

selinux: create Vagrantfile for SELinux #2900

Merged

Gekko0114 mentioned this pull request Sep 29, 2024

selinux: fix xattr and remove anyhow #2936

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

selinux: implemented remaining selinux functions #2850

selinux: implemented remaining selinux functions #2850

Gekko0114 commented Jul 14, 2024 •

edited

Loading

Gekko0114 commented Jul 19, 2024

utam0k left a comment

Gekko0114 commented Jul 22, 2024

Gekko0114 commented Jul 30, 2024

utam0k commented Jul 30, 2024

utam0k left a comment •

edited

Loading

utam0k left a comment

utam0k commented Aug 3, 2024

Gekko0114 commented Aug 3, 2024

utam0k commented Aug 5, 2024

Gekko0114 commented Aug 5, 2024 •

edited

Loading

YJDoc2 commented Aug 8, 2024

Gekko0114 commented Aug 8, 2024

utam0k commented Aug 16, 2024

utam0k left a comment

selinux: implemented remaining selinux functions #2850

selinux: implemented remaining selinux functions #2850

Conversation

Gekko0114 commented Jul 14, 2024 • edited Loading

Gekko0114 commented Jul 19, 2024

utam0k left a comment

Choose a reason for hiding this comment

Gekko0114 commented Jul 22, 2024

Gekko0114 commented Jul 30, 2024

utam0k commented Jul 30, 2024

utam0k left a comment • edited Loading

Choose a reason for hiding this comment

utam0k left a comment

Choose a reason for hiding this comment

utam0k commented Aug 3, 2024

Gekko0114 commented Aug 3, 2024

utam0k commented Aug 5, 2024

Gekko0114 commented Aug 5, 2024 • edited Loading

YJDoc2 commented Aug 8, 2024

Gekko0114 commented Aug 8, 2024

utam0k commented Aug 16, 2024

utam0k left a comment

Choose a reason for hiding this comment

Gekko0114 commented Jul 14, 2024 •

edited

Loading

utam0k left a comment •

edited

Loading

Gekko0114 commented Aug 5, 2024 •

edited

Loading