Extend info cmd with status of cgroup controllers #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should hold this off until the upgrade to the new oci-spec release is completed. |
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 69.73% 69.79% +0.05%
==========================================
Files 46 46
Lines 5687 5688 +1
==========================================
+ Hits 3966 3970 +4
+ Misses 1721 1718 -3 |
I agree with you. |
|
@utam0k PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds which controllers are attached to the cgroup v2 hierarchy. For devices I just check if it is possible to attach epbf programs to a cgroup. I also moved the freezer controller to pseudo controllers. While contrary to devices and unified, this is a real subsystem it is also quite different from the other controllers. More importantly you cannot read it from cgroup.controllers, nor write it to subtree_control which was one of the original motivations for introducing this distinction.