-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a workspace to enable execution of commands in bulk. #287
Conversation
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 73.36% 77.26% +3.89%
==========================================
Files 46 42 -4
Lines 6229 5920 -309
==========================================
+ Hits 4570 4574 +4
+ Misses 1659 1346 -313 |
a4c6150
to
f303123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
I think as workspace makes the /target dir common for both (youki and cgroups), so we might be able to remove the separate cache action for cgroups as well, will have to check that.
In cgroups I think you were trying to extract common statement outside if-else, but it might create issues for #266 ? It is already having issues with merge conflicts with existing files, so I feel it'd be better to leave those changes for @guni1192 to add in their PR. What do you think?
You can leave it out. My open PR contains the same change, so it will not get lost. |
Oh wait, I don't think this will work, because with the workspace clippy will flag the code now. |
Additionally we can remove the Cargo.lock file in cgroups, and combine the separate cache actions, as the compiled cgroups files are kept in the youki's target/ only. https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html
Other than that lgtm 👍 |
@YJDoc2 Oh thanks for the review. I've taken care of it. |
…ment/workspace-members
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 if you want to keep cache actions separate for now.
We could certainly organize it. I'll consider it in another PR. |
No description provided.