Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nc dependency to 0.9.2 #2884

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

posutsai
Copy link
Contributor

Hi, new to youki here. Hope to start my contribution from a simple issue #2874.

  1. Instead of updating to 0.9.1, I update to 0.9.2
  2. Since the size parameter is needless, I remove it.

Please let me know if I do anything wrong. Thank you and hope to do more contribution.

Signed-off-by: posutsai <posutsai@gmail.com>
@YJDoc2 YJDoc2 changed the title Update Cargo.toml in libcontainer and runtimetest Update nc dependency to 0.9.2 Aug 20, 2024
@YJDoc2 YJDoc2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 20, 2024
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Aug 20, 2024

Hey the lint CI is failing - https://github.com/containers/youki/actions/runs/10454851896/job/28979505684?pr=2884 . Also, you will need to resolve conflicts due to another dependabot pr getting merged.

Signed-off-by: posutsai <posutsai@gmail.com>
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change as a result of conflict resolve, otherwise ok.

tests/contest/runtimetest/Cargo.toml Outdated Show resolved Hide resolved
@YJDoc2 YJDoc2 linked an issue Aug 20, 2024 that may be closed by this pull request
Signed-off-by: posutsai <posutsai@gmail.com>
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for contributing!

@YJDoc2 YJDoc2 merged commit 1749ef3 into youki-dev:main Aug 20, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Aug 20, 2024
@posutsai posutsai deleted the issue-2874-update-nc branch August 21, 2024 03:58
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update nc from 0.8.23 to 0.9.1
2 participants