-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nc dependency to 0.9.2 #2884
Conversation
Signed-off-by: posutsai <posutsai@gmail.com>
b045e1a
to
362226c
Compare
Hey the lint CI is failing - https://github.com/containers/youki/actions/runs/10454851896/job/28979505684?pr=2884 . Also, you will need to resolve conflicts due to another dependabot pr getting merged. |
Signed-off-by: posutsai <posutsai@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor change as a result of conflict resolve, otherwise ok.
Signed-off-by: posutsai <posutsai@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks for contributing!
Hi, new to youki here. Hope to start my contribution from a simple issue #2874.
size
parameter is needless, I remove it.Please let me know if I do anything wrong. Thank you and hope to do more contribution.