Fix --preserve-fds, eliminate stray FD being passed into container #2893
+308
−66
Commits on Aug 30, 2024
-
Signed-off-by: Aidan Hobson Sayers <aidanhs@cantab.net>
Commits on Sep 1, 2024
-
Fix a stray FD leaking in containers when using preserve-fd
Signed-off-by: Aidan Hobson Sayers <aidanhs@cantab.net>
Commits on Sep 2, 2024
-
Add tests for preserve-fds, extend test harness
Test harness additionally needed to support 1. tests that cannot run in parallel 2. tests that need to customise create arguments Signed-off-by: Aidan Hobson Sayers <aidanhs@cantab.net>
Commits on Sep 3, 2024
-
Opt-out a test from runc that it errors on
Signed-off-by: Aidan Hobson Sayers <aidanhs@cantab.net>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.