Add seccomp into feature flags of youki to be compiled in #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musaprg
force-pushed
the
add-seccomp-support-build-feature-for-youki-crate
branch
from
ea5f849
to
873ca84
Compare
|
In short, not all platform supports libseccomp. There are some context in these issues and MR. Please read them and I can help answer further questions :) |
YJDoc2
added
the
kind/cleanup
|
May I ask you to check CI? |
Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
musaprg
force-pushed
the
add-seccomp-support-build-feature-for-youki-crate
branch
from
873ca84
to
a34dcc0
Compare
Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
|
Hi. I rechecked and fixed my changes to the test cases. Could you check it again? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the youki disables the
libcontainer/libseccompfeature by settingdefault-feature = false. If libcontainer has a feature flag for seccomp, youki should also have the feature flag so that we can use it by enabling it through the build option.Since I'm new to this project, I don't have enough background and status of seccomp support in youki. Please let me know if there's any reason why this feature is explicitly disabled in youki, for example, it's still an experimental feature.