-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a failure when dirs is empty at changes job. #294
Conversation
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 69.76% 69.78% +0.01%
==========================================
Files 46 46
Lines 5699 5699
==========================================
+ Hits 3976 3977 +1
+ Misses 1723 1722 -1 |
|
f4a7fb6
to
23f478f
Compare
b594497
to
c81ccab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, have you tested this when no code changes are there? Asking because in https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#contains it states that for arrays, it checks if the element is in the array. So as needs.changes.outputs.dirs itself is an array , wouldn't
contains(needs.changes.outputs.dirs, '[]')
check if []
is an element in the dirs, and not dirs itself is an empty array? Maybe I am wrong, as I haven't worked with github actions expressions either, so if you have run this with no code changes and this works, lgtm 👍
8947cd6
to
23f478f
Compare
@YJDoc2 This seems to work for now. The pattern with no code changes is ci of this PR ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes! I missed that 😅 All well then 👍
Also in one of previous commits in this PR, you had made a separate job for dependencies, was there any issue with that? Or were the dependencies not sharable across jobs? |
That way of writing was completely wrong and I needed to think of another way. |
fix #284