-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create mount_rootfs method #2953
Conversation
25efa47
to
af4da35
Compare
@Gekko0114 , Thanks for implementing this, but may I ask you to wait for/coordinate with #2923 as that also changes the mount impl. |
Sure, then I will wait this PR will be merged. |
@Gekko0114 the other PR is merged, you can rebase on main and continue your work here. |
Signed-off-by: Hiroyuki Moriya <41197469+Gekko0114@users.noreply.github.com>
Hi @YJDoc2, |
Hey, it looks ok overall, but can you give a bit more reasoning behind this change? I mean, I understand that this is done to make the logic same in youki and runc, but why is that needed, and what this split of function will achieve (eventually) ? |
Hi @YJDoc2 In Runc, processing differs for each device of the mount point. https://github.com/opencontainers/runc/blob/d5e4c33001d74176222fe8f48a323f3e8ad89999/libcontainer/rootfs_linux.go#L485 Therefore, I plan to address this issue. First I created a mount_to_rootfs function, and then I will add processing for each device of the mount point. |
ok, Ideally we should try to do it our own way in a single function if possible, but I see that the individual mount fn in runc is quite complex, so maybe we should break our function in two as well. In the following PRs, please check if we can do it differently or more rust-idiomatically. Merging this for now. |
The implementation of mounting differs between Youki and runc.
#2718
Therefore, we want to modify Youki to adopt runc's mounting logic.
As the first step, I've created a new method
mount_rootfs
.I will implement the mounting logic step by step in this method.