Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add process test #2968

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add process test #2968

wants to merge 9 commits into from

Conversation

sat0ken
Copy link
Contributor

@sat0ken sat0ken commented Oct 30, 2024

This implements the process validation in #361.

@sat0ken
Add process test
b156f6b 
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
@sat0ken
Merge branch 'containers:main' into add-test-process
43a6d7a
@sat0ken
rm unused imports
78dfb54 
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
@sat0ken
fix err
aef1f45 
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
@sat0ken
Merge branch 'main' into add-test-process
1926533
@sat0ken
fix set env
3d52b59 
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
@sat0ken
fix format err
ef26e24 
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
@sat0ken
add mkdir for test
846df14 
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
@sat0ken
set permision to /test
94526b2 
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
@sat0ken
Copy link
Contributor Author

sat0ken commented Nov 1, 2024 •
edited
Loading

@utam0k @YJDoc2

I figure out why the test failed.

I reproduced it on my PC.
If /test does not exist in the rootfs, the youki execution will fail same as the E2E tests.

root@satoken:~/work/rootfs# ls
bin  boot  config.json  dev  etc  home  lib  lib64  media  mnt  opt  proc  root  run  sbin  srv  sys  tmp  usr  var
root@satoken:~/work/rootfs# youki run test
ERROR libcontainer::process::container_init_process: failed to chdir e=ENOENT
ERROR libcontainer::process::container_intermediate_process: failed to initialize container process: failed to unix syscall
ERROR libcontainer::process::container_main_process: failed to wait for init ready: exec process failed with error error in executing process : failed to unix syscall
ERROR libcontainer::container::builder_impl: failed to run container process exec process failed with error error in executing process : failed to unix syscall
ERROR youki: error in executing command: exec process failed with error error in executing process : failed to unix syscall
run failed : exec process failed with error error in executing process : failed to unix syscall

But runc is, even if /test is not in rootfs, runc run is working.

root@satoken:~/work/rootfs# ls
bin  boot  config.json  dev  etc  home  lib  lib64  media  mnt  opt  proc  root  run  sbin  srv  sys  tmp  usr  var
root@satoken:~/work/rootfs# runc run test
/test

If we add a test directory to the rootfs you use for testing, the tests will pass.
However, to resolve the error, maybe I need to check youki's code that prepares the rootfs?

Sorry, I don't understand the detailed code of runc or youki, but I think it looks like runc is creating the cwd directory in this line.

What is the difference between the behavior of runc and youki?

@sat0ken
Copy link
Contributor Author

sat0ken commented Nov 4, 2024

@utam0k @YJDoc2 ping!
Please confirm.

#2968 (comment)

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 4, 2024

Hey, thanks for the ping, I'll try to take a look at this today.

YJDoc2
YJDoc2 requested changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, also there are several warnings from the CI check, please take a look

tests/contest/runtimetest/src/main.rs
@@ -20,7 +20,6 @@ fn get_spec() -> Spec {
}
}

////////// ANCHOR: example_runtimetest_main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line removed here?

tests/contest/contest/src/tests/process/process_test.rs
fn process_test() -> TestResult {
let spec = test_result!(create_spec());
test_inside_container(spec, &|_| {
match fs::create_dir("/test") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be /test, you should take the bundle param in the closure and append /test and create that dir. This callback is run in host's fs before running the container, so you should be using bundle path and create this dir.

tests/contest/runtimetest/src/tests.rs
use std::fs::{self, read_dir};
use std::os::linux::fs::MetadataExt;
use std::os::unix::fs::{FileTypeExt, PermissionsExt};
use std::path::Path;

use anyhow::{bail, Result};

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this extra blank line.

tests/contest/runtimetest/src/tests.rs
Comment on lines +562 to +577
if env::var("testa").unwrap().to_string().ne("valuea") {
eprintln!(
"error due to spec environment value of testa want {:?}, got {:?}",
"valuea",
env::var("testa")
)
}

if env::var("testb").unwrap().to_string().ne("123") {
eprintln!(
"error due to spec environment value of testb want {:?}, got {:?}",
"123",
env::var("testb")
)
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this as well, we should cross check this with env from the spec, similar to how the go test is doing.

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 5, 2024

Hey @sat0ken , I took a look at the code and there are two things -

  1. In the test (as per my comment), you are not creating the /test dir correctly. Hence youki does not find it and fails.
  2. As for if to to follow or not runc's way of creating the cwd if not present, I think we should check and stick to the runtime spec, I'll check and get back to you. But if the failing test is fixed by correctly creating the dir, then maybe we should not copy this.

@YJDoc2 YJDoc2 mentioned this pull request Nov 5, 2024
Open
60 tasks
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 5, 2024

Also @sat0ken a small request, please ping/comment in the tracking issue before opening a e2e test PR, so we can properly keep track. I have added your current PRs, but please comment for future ones. Thanks!

@sat0ken
Copy link
Contributor Author

sat0ken commented Nov 6, 2024

@YJDoc2
Thank you for your comments and confirmation. I will fix the code.
I am newbie to contribution, so I apologize for not following the rules. Thank you for your continued support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YJDoc2 YJDoc2 YJDoc2 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sat0ken @YJDoc2 @utam0k