Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sipliy split init.rs into several files. #297

Merged
merged 2 commits into from
Sep 13, 2021
Merged

sipliy split init.rs into several files. #297

merged 2 commits into from
Sep 13, 2021

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Sep 12, 2021 •
edited
Loading

relate #295

@utam0k
Copy link
Member Author

utam0k commented Sep 12, 2021

@yihuaf @Furisto @YJDoc2 What do you think of this PR?

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021 •
edited
Loading

Codecov Report

Merging #297 (47f003c) into main (7aaa2fb) will increase coverage by 4.44%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   68.92%   73.36%   +4.44%     
==========================================
  Files          46       46              
  Lines        5837     6229     +392     
==========================================
+ Hits         4023     4570     +547     
+ Misses       1814     1659     -155

@yihuaf
Copy link
Collaborator

yihuaf commented Sep 12, 2021

Changes looks good. I think splitting in this case can go either way. On one hand, the file is not that long and having everything in one file actually helps the understanding. I will admit, init.rs is probably the wrong name if we keep these functions in one file. On the other hand, I like how you split up the code.

yihuaf
yihuaf approved these changes Sep 12, 2021
View reviewed changes
Copy link
Collaborator

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, the change itself LGTM. I am OK with splitting or not.

src/process/intermediate.rs Outdated
use oci_spec::runtime::{LinuxNamespaceType};



Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: that's a lot of empty lines :)

YJDoc2
YJDoc2 approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@utam0k utam0k merged commit 9844d84 into youki-dev:main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YJDoc2 YJDoc2 YJDoc2 approved these changes

@Furisto Furisto Furisto approved these changes

@yihuaf yihuaf yihuaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@utam0k @codecov-commenter @yihuaf @Furisto @YJDoc2