Add test process user #2978
Open
Add test process user #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
… add-test-process-user
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
60 tasks
YJDoc2
requested changes
Nov 6, 2024
| let current_umask = unsafe { libc::umask(0) }; | ||
| unsafe { libc::umask(current_umask) }; | ||
|
|
||
| if process.user().uid().ne(&uid) { |
There was a problem hiding this comment.
I think you should be able to directly use != operator. Same for below.
| @@ -471,3 +472,37 @@ pub fn test_mount_rsuid_option(path: &str) -> Result<(), std::io::Error> { | |||
| format!("rsuid error {path:?}"), | |||
| )) | |||
| } | |||
|
|
|||
| pub fn test_additional_gids(gids: &Vec<u32>) -> Result<(), std::io::Error> { | |||
There was a problem hiding this comment.
I think we can move this to the test file itself, I don't think we will be using this anywhere else.
Also please use safe alternatives from nix instead of unsafe from libc.
Can you add comments explaining what this is trying to do? The original go does not have comments, so it would be good to have explanation here.
Comment on lines
+17
to
+20
| ProcessBuilder::default() | ||
| .user(user) | ||
| .build() | ||
| .expect("error in creating process config"), |
There was a problem hiding this comment.
You need to set the process cmd to the runtimetest to actually run the internal test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the process_user validation in #361