Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Changes Job in CI #306

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Fix Changes Job in CI #306

merged 1 commit into from
Sep 18, 2021

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Sep 18, 2021

the quotes ('') in the changes job failed to glob match the changed files, and thus the check job was not run. This PR fixes that, as well as add seccomp directory in changes.

@YJDoc2 YJDoc2 requested a review from utam0k September 18, 2021 15:23
@codecov-commenter
Copy link

Codecov Report

Merging #306 (a17e4f2) into main (74ed630) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   77.19%   77.17%   -0.02%     
==========================================
  Files          43       43              
  Lines        6139     6139              
==========================================
- Hits         4739     4738       -1     
- Misses       1400     1401       +1     

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Sep 18, 2021

@utam0k Please take a look, I have changed the glob pattern

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@utam0k utam0k merged commit f81b08a into youki-dev:main Sep 18, 2021
@YJDoc2 YJDoc2 deleted the fix_ci_changes_job branch September 25, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants