-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make container commands more suitable for use as a library #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furisto
changed the title
Make container commands more suitable for use as a library
[WIP] Make container commands more suitable for use as a library
Sep 20, 2021
@alfonsoros88 Hi! Maybe you are interested in this PR. so I'll give you the mention. |
Codecov Report
@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 73.09% 70.94% -2.15%
==========================================
Files 44 46 +2
Lines 6541 6811 +270
==========================================
+ Hits 4781 4832 +51
- Misses 1760 1979 +219 |
Furisto
force-pushed
the
libcontainer
branch
from
September 24, 2021 10:01
cb9382d
to
a4bac01
Compare
|
Furisto
changed the title
[WIP] Make container commands more suitable for use as a library
Make container commands more suitable for use as a library
Sep 24, 2021
utam0k
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to make it easier to use youki as library, so it can be reused in different contexts.