Ensure cgroup error behavior is consistent with runc #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
==========================================
- Coverage 71.14% 70.61% -0.53%
==========================================
Files 46 46
Lines 6828 6882 +54
==========================================
+ Hits 4858 4860 +2
- Misses 1970 2022 +52 |
utam0k
reviewed
Sep 26, 2021
cgroups/src/common.rs
Outdated
| @@ -355,3 +356,21 @@ pub(crate) fn default_devices() -> Vec<LinuxDevice> { | |||
| }, | |||
| ] | |||
| } | |||
|
|
|||
| pub(crate) fn delete_with_retry<P: AsRef<Path>>(path: P) -> Result<()> { | |||
There was a problem hiding this comment.
I think it is more versatile to have the number of retries and the delay as arguments. What do you think?
|
Sorry for the delay, I checked, and this is now consistent with runc. This should fix and close #328 . Thanks for the fix, now I will go ahead with rest of the integration test 👍 😄 |
Furisto
force-pushed
the
cg-delete
branch
2 times, most recently
from
b9ac863
to
a47506e
Compare
|
@utam0k PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #328.
@YJDoc2 Can you confirm that this fixes your problem?