add to README that all runtime_tools tests have been covered. #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
commented
Sep 26, 2021
| @@ -48,7 +48,7 @@ youki is not at the practical stage yet. However, it is getting closer to practi | |||
| | Seccomp | Filtering system calls | ✅ | | |||
| | Hooks | Add custom processing during container creation | ✅ | | |||
| | Rootless | Running a container without root privileges | It works, but cgroups isn't supported. WIP on [#77](https://github.com/containers/youki/issues/77) | | |||
| | OCI Compliance | Compliance with OCI Runtime Spec | 50 out of 52 test cases passing | | |||
| | OCI Compliance | Compliance with OCI Runtime Spec | ✅ 50 out of 50 test cases passing | | |||
There was a problem hiding this comment.
The remaining ones are tests that cannot be run due to runtime_tools.
There was a problem hiding this comment.
This means that even runc doesn't pass them, right?
There was a problem hiding this comment.
Yes, it is. For more details, see integration.sh, including the reason.
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage 71.17% 71.17%
=======================================
Files 46 46
Lines 6828 6828
=======================================
Hits 4860 4860
Misses 1968 1968 |
Furisto
approved these changes
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉
fix #252