Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Youki with latest oci-spec-rs #364

Merged
merged 6 commits into from
Oct 7, 2021
Merged

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented Oct 5, 2021

Now that setters are in, remove the boilerplate code.

@yihuaf
Copy link
Collaborator Author

yihuaf commented Oct 5, 2021

There is a bug in the oci-spec-rs. Pending PR: youki-dev/oci-spec-rs#78

@yihuaf
Copy link
Collaborator Author

yihuaf commented Oct 6, 2021

There is a bug in the oci-spec-rs. Pending PR: containers/oci-spec-rs#78

Resolved and ready for review.

@yihuaf yihuaf requested a review from utam0k October 6, 2021 16:53
@codecov-commenter
Copy link

Codecov Report

Merging #364 (3c075f8) into main (b5089f3) will increase coverage by 73.15%.
The diff coverage is 86.66%.

@@            Coverage Diff            @@
##           main     #364       +/-   ##
=========================================
+ Coverage      0   73.15%   +73.15%     
=========================================
  Files         0       48       +48     
  Lines         0     7721     +7721     
=========================================
+ Hits          0     5648     +5648     
- Misses        0     2073     +2073     

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utam0k utam0k merged commit 07d925a into youki-dev:main Oct 7, 2021
@yihuaf yihuaf deleted the yihuaf/oci-spec branch October 8, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants