-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
279 increate the code coverage of src container #376
279 increate the code coverage of src container #376
Conversation
Codecov Report
@@ Coverage Diff @@
## main #376 +/- ##
==========================================
+ Coverage 74.63% 76.72% +2.08%
==========================================
Files 51 51
Lines 7759 7870 +111
==========================================
+ Hits 5791 6038 +247
+ Misses 1968 1832 -136 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main concern is to use Result, not is_ok
and unwrap
. Otherwise, good PR.
Thanks for teaching me that! Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#279
the container/container part