Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

279 increate the code coverage of src container #376

Merged

Conversation

tommady
Copy link
Collaborator

@tommady tommady commented Oct 9, 2021

#279
the container/container part

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2021

Codecov Report

Merging #376 (36a4de9) into main (f1acccb) will increase coverage by 2.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
+ Coverage   74.63%   76.72%   +2.08%     
==========================================
  Files          51       51              
  Lines        7759     7870     +111     
==========================================
+ Hits         5791     6038     +247     
+ Misses       1968     1832     -136     

@tommady tommady changed the title [WIP] 279 increate the code coverage of src container 279 increate the code coverage of src container Oct 9, 2021
@tommady tommady marked this pull request as ready for review October 9, 2021 14:52
Copy link
Collaborator

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main concern is to use Result, not is_ok and unwrap. Otherwise, good PR.

src/container/container.rs Outdated Show resolved Hide resolved
src/container/container.rs Outdated Show resolved Hide resolved
src/container/container.rs Outdated Show resolved Hide resolved
src/container/container.rs Outdated Show resolved Hide resolved
@tommady
Copy link
Collaborator Author

tommady commented Oct 10, 2021

Thanks for teaching me that!
I didn't know that,
Will addressed.

Thanks again!

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utam0k utam0k merged commit d907c13 into youki-dev:main Oct 10, 2021
@tommady tommady deleted the 279-increate-the-code-coverage-of-src-container branch October 10, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants