increate the code coverage of src process part2 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 68.24% 69.35% +1.11%
==========================================
Files 76 76
Lines 9887 10002 +115
==========================================
+ Hits 6747 6937 +190
+ Misses 3140 3065 -75 |
yihuaf
reviewed
Oct 26, 2021
…ner-init-process-2
tommady
force-pushed
the
279-increate-the-code-coverage-of-src-container-init-process-2
branch
from
ad1f724
to
62caaef
Compare
tommady
changed the title
Furisto
reviewed
Oct 29, 2021
| @@ -218,35 +218,35 @@ impl Syscall for LinuxSyscall { | |||
| ) -> Result<()> { | |||
| match mount(source, target, fstype, flags, data) { | |||
| Ok(_) => Ok(()), | |||
| Err(e) => bail!("Failed to mount {:?}", e), | |||
There was a problem hiding this comment.
because I found out by using bail!
the downcast_ref() will fail to parse out the source error,
if let Some(errno) = e.downcast_ref()
this condition will fail.
then the integration test will fail on the masked_path check.
please guide me if I am wrong.
Furisto
approved these changes
Oct 29, 2021
|
Looks good. |
tommady
deleted the
279-increate-the-code-coverage-of-src-container-init-process-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#279
the process/container_init_process part 2