Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a ci for the first release. #458

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Nov 7, 2021

No description provided.

@utam0k utam0k changed the title add a ci for release build. add a ci for the first release. Nov 7, 2021
@utam0k
Copy link
Member Author

utam0k commented Nov 7, 2021

@codecov-commenter
Copy link

Codecov Report

Merging #458 (4ca7418) into main (3dde97f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files          82       82           
  Lines       12148    12148           
=======================================
  Hits         7347     7347           
  Misses       4801     4801           

@utam0k
Copy link
Member Author

utam0k commented Nov 10, 2021

@Furisto @yihuaf @tsturzl
Can I have your review?

Copy link
Collaborator

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assume this is tested. On a side note, we should look into how to share some of the steps in the CI. We have accumulated a decent number of code duplication.

@yihuaf yihuaf merged commit 4318258 into youki-dev:main Nov 11, 2021
@utam0k
Copy link
Member Author

utam0k commented Nov 11, 2021

GTM assume this is tested. On a side note, we should look into how to share some of the steps in the CI. We have accumulated a decent number of code duplication.

I've considered this before but gave up because it seemed too difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants