Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: adjusting the position of parameters and flag declarations #474

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

unknowndevQwQ
Copy link
Contributor

Split from #465
Because this pr does not have much to do with #465

@utam0k
Copy link
Member

utam0k commented Nov 14, 2021

@unknowndevQwQ Why we need this change?

@codecov-commenter
Copy link

Codecov Report

Merging #474 (1f3d94e) into main (afe4921) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   60.40%   60.44%   +0.04%     
==========================================
  Files          82       82              
  Lines       12150    12150              
==========================================
+ Hits         7339     7344       +5     
+ Misses       4811     4806       -5     

@unknowndevQwQ
Copy link
Contributor Author

unknowndevQwQ commented Nov 14, 2021

@unknowndevQwQ Why we need this change?

It will become a little more organized

When trying to add the --debug flag, I didn't even realize where the --root flag was declared

@utam0k
Copy link
Member

utam0k commented Nov 15, 2021

@unknowndevQwQ Why we need this change?

It will become a little more organized

When trying to add the --debug flag, I didn't even realize where the --root flag was declared

I don't understand what changes of this PR improve. Would you please explain it to me?

@unknowndevQwQ
Copy link
Contributor Author

@unknowndevQwQ Why we need this change?

It will become a little more organized
When trying to add the --debug flag, I didn't even realize where the --root flag was declared

I don't understand what changes of this PR improve. Would you please explain it to me?

The ordering of the parameter names in a-z order facilitates a quicker and more accurate search for the relevant content of a parameter when there are quite a few of them.

@utam0k utam0k merged commit ba08bb3 into youki-dev:main Nov 15, 2021
@unknowndevQwQ unknowndevQwQ deleted the adjusting_the_position branch November 16, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants