Create a subdirectory under XDG_RUNTIME_DIR #488
Conversation
When using a root state directory from $XDG_RUNTIME_DIR, or from it's default value of /run/user/<uid>, we don't add a tag specific to youki to the path. That means the directories for individual containers will be placed directly in the general use runtime dir. That's against normal conventions, and could mean that "youki list" will see files or directories from other software as if they were youki managed containers. Therefore, add "youki" to the base runtime path from XDG. fixes youki-dev#487 Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
|
/cc @c3d |
| if create_dir_all_with_mode(&path, uid, Mode::S_IRWXU).is_ok() { | ||
| return Ok(path); | ||
| } |
There was a problem hiding this comment.
If it fails, it must return with an error or the process will continue, which is what you are aiming for, right?
There was a problem hiding this comment.
Well, not immediately. If this create fails we continue onto the remaining options ($HOME/.youki/run then /tmp/youki/<uid>). AFAICT that's what happened before, and I'm not intending to change that.
There was a problem hiding this comment.
That is correct. If we cannot get the preferred location (which is XDG_RUNTIME_DIR), we try a bunch of other locations that may be suitable before we give up.
Codecov Report
@@ Coverage Diff @@
## main #488 +/- ##
==========================================
- Coverage 61.08% 61.07% -0.01%
==========================================
Files 85 85
Lines 12416 12417 +1
==========================================
Hits 7584 7584
- Misses 4832 4833 +1 |
|
Looks good to me. |
|
@dgibson Thanks for your contribution! |
When using a root state directory from $XDG_RUNTIME_DIR, or from it's
default value of /run/user/, we don't add a tag specific to youki
to the path. That means the directories for individual containers
will be placed directly in the general use runtime dir.
That's against normal conventions, and could mean that "youki list"
will see files or directories from other software as if they were
youki managed containers. Therefore, add "youki" to the base runtime
path from XDG.
fixes #487
Signed-off-by: David Gibson david@gibson.dropbear.id.au