-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement the update subcommand(partially) #536
Conversation
/cc @utam0k One thing I am curious is that now we read the cgroup path from the |
The CI failure is due to some clippy warnings that need to be fixed |
Also the clippy warnings still need to be fixed and the pnet package seems to be specified twice in the cargo.lock file now. |
1fc65f3
to
c77dd60
Compare
Codecov Report
@@ Coverage Diff @@
## main #536 +/- ##
==========================================
- Coverage 61.09% 60.51% -0.59%
==========================================
Files 85 99 +14
Lines 12532 12643 +111
==========================================
- Hits 7657 7651 -6
- Misses 4875 4992 +117 |
@knight42 |
ddae87d
to
9dcae42
Compare
@utam0k Hi! I believe this issue has been fixed in this PR based on @Furisto 's suggestion here. @Furisto Would you like to take another look? |
@knight42 Looks good! One last thing: Can you please squash the last 4 commits into one and name it "Address review comments" or something like that? Otherwise LGTM! |
9dcae42
to
aa9103a
Compare
@Furisto Hi! I have already squashed the commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
@knight42 Can you resolve the merge conflicts? |
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
aa9103a
to
09ecfba
Compare
@Furisto Fixed now. |
@knight42 Awesome! |
Ref #147
This PR did several things:
oci-spec
to the latestcreate_cgroup_manager
which could be used inps
andupdate
commandupdate
subcommand and make it be abled to changed the pids limit in the container