Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --resource option to update subcommand #546

Merged
merged 1 commit into from
Dec 19, 2021

Conversation

knight42
Copy link
Contributor

Signed-off-by: Jian Zeng anonymousknight96@gmail.com

ref #147

Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #546 (21eaf4e) into main (7d63d2a) will increase coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
+ Coverage   60.56%   61.13%   +0.57%     
==========================================
  Files          99       85      -14     
  Lines       12673    12563     -110     
==========================================
+ Hits         7676     7681       +5     
+ Misses       4997     4882     -115     

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knight42 Looks good. However, integration tests about the update subcommand may be necessary.

@utam0k utam0k merged commit 468e9fb into youki-dev:main Dec 19, 2021
@knight42 knight42 deleted the feat/update-resources branch December 19, 2021 03:53
@knight42
Copy link
Contributor Author

@knight42 Looks good. However, integration tests about the update subcommand may be necessary.

Okay! I will file another PR to add the integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants