Interpret a cpu quota of zero as default value #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runc interprets a a zero quota value as unrestricted.
Codecov Report
@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 60.59% 60.63% +0.04%
==========================================
Files 99 99
Lines 12678 12667 -11
==========================================
- Hits 7682 7681 -1
+ Misses 4996 4986 -10 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runc interpretes a cpu quota of zero as an instruction to set the default value for cpu quota. As runtimes like CRI-O depend on this behavior we should do the same.