Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create integration tests. #583

Closed
wants to merge 2 commits into from
Closed

Add create integration tests. #583

wants to merge 2 commits into from

Conversation

whereistejas
Copy link

@whereistejas whereistejas commented Dec 31, 2021

This PR is meant to add create integration tests which are bring tracked in #361.

I will outline the basic approach I have decided to add the necessary tests:

  1. Remove ContainerCreate struct.
  2. Replace it with something similar to syntax such as get_test_group.
  3. ... (I will add more stuff here, as I go on)

Signed-off-by: Tejas Sanap sanap.tejas@gmail.com

Signed-off-by: Tejas Sanap <sanap.tejas@gmail.com>
@whereistejas whereistejas marked this pull request as draft December 31, 2021 14:19
@whereistejas whereistejas changed the title Add create module. Add create integration tests. Dec 31, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #583 (6c58724) into main (154655c) will decrease coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   61.18%   60.64%   -0.55%     
==========================================
  Files          85       99      +14     
  Lines       12553    12667     +114     
==========================================
+ Hits         7681     7682       +1     
- Misses       4872     4985     +113     

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jan 19, 2022

Hey @whereistejas are you still working on this?

@Furisto
Copy link
Collaborator

Furisto commented Feb 24, 2022

Considering that this has been stale for almost 2 months now, I will close this. Feel free to reopen if you want to continue.

@Furisto Furisto closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants