-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the runtime-tools directory one level deeper. #614
make the runtime-tools directory one level deeper. #614
Conversation
b2ea29d
to
3722283
Compare
Hey, I tried this with different combinations, and when running on my system locally it works fine. After searching a bit, I feel this issue is due to some problem in current nightly. I'm updating my nightly will update here after checking with current nightly. |
Hey, I could reproduce the same error that is in the CI with today's (16 Jan 2022) nightly on my local system. The CI steps worked fine with the previous nightly I had installed, so I don't think this is any error in the PR changes. That said , can you take a look at https://github.com/YJDoc2/youki/runs/4831134294?check_suite_focus=true , in this the Thanks :) |
3722283
to
6587ab1
Compare
Maybe you forgot to change the submodule, i.e. |
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
==========================================
- Coverage 70.01% 70.00% -0.01%
==========================================
Files 82 82
Lines 10933 10933
==========================================
- Hits 7655 7654 -1
- Misses 3278 3279 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this looks good to me 👍
Are you still making any changes here, or is it fine to merge?
No, I am. I'll merge this. |
First step of #601