Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the runtime-tools directory one level deeper. #614

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jan 16, 2022

First step of #601

@utam0k utam0k force-pushed the improvement/make-runtime-tools-deeper branch 2 times, most recently from b2ea29d to 3722283 Compare January 16, 2022 05:46
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jan 16, 2022

Hey, I tried this with different combinations, and when running on my system locally it works fine. After searching a bit, I feel this issue is due to some problem in current nightly. I'm updating my nightly will update here after checking with current nightly.

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jan 16, 2022

Hey, I could reproduce the same error that is in the CI with today's (16 Jan 2022) nightly on my local system. The CI steps worked fine with the previous nightly I had installed, so I don't think this is any error in the PR changes.

That said , can you take a look at https://github.com/YJDoc2/youki/runs/4831134294?check_suite_focus=true , in this the integration_test workflow seems to be failing due to some git checkout issue, which is not occurring in this PR.

Thanks :)

.github/workflows/main.yml Outdated Show resolved Hide resolved
@utam0k utam0k force-pushed the improvement/make-runtime-tools-deeper branch from 3722283 to 6587ab1 Compare January 16, 2022 12:13
@utam0k
Copy link
Member Author

utam0k commented Jan 16, 2022

Hey, I could reproduce the same error that is in the CI with today's (16 Jan 2022) nightly on my local system. The CI steps worked fine with the previous nightly I had installed, so I don't think this is any error in the PR changes.

That said , can you take a look at https://github.com/YJDoc2/youki/runs/4831134294?check_suite_focus=true , in this the integration_test workflow seems to be failing due to some git checkout issue, which is not occurring in this PR.

Thanks :)

Maybe you forgot to change the submodule, i.e. git mv?

@codecov-commenter
Copy link

Codecov Report

Merging #614 (d0136c6) into main (63f77b2) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   70.01%   70.00%   -0.01%     
==========================================
  Files          82       82              
  Lines       10933    10933              
==========================================
- Hits         7655     7654       -1     
- Misses       3278     3279       +1     

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks good to me 👍
Are you still making any changes here, or is it fine to merge?

@utam0k
Copy link
Member Author

utam0k commented Jan 18, 2022

Hey, this looks good to me 👍 Are you still making any changes here, or is it fine to merge?

No, I am. I'll merge this.

@utam0k utam0k merged commit 462f332 into youki-dev:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants