ready for integration test for the exec command. #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YJDoc2
reviewed
Jan 21, 2022
There was a problem hiding this comment.
Hey this is a very good idea to add an exec test! I don't think the original oci-tests had exec separately tests, which is why we might have forgotten to add this originally, but definitely a needed addition 👍
I have added a couple of comments, please take a look at them :)
crates/integration_test/src/tests/lifecycle/container_lifecycle.rs
Outdated
Show resolved
Hide resolved
|
@YJDoc2 PTAL |
|
Hey, This is great, we can merge this now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
youki's exec command is now broken 😭
cc: @Furisto
I've checked that this pr works fine using
runc.