Always use the same permissions for youki dir #705
Conversation
Signed-off-by: Szymon Gibała <szymongib@gmail.com>
Signed-off-by: Szymon Gibała <szymongib@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #705 +/- ##
==========================================
- Coverage 70.77% 70.58% -0.19%
==========================================
Files 84 100 +16
Lines 11144 11349 +205
==========================================
+ Hits 7887 8011 +124
- Misses 3257 3338 +81 |
|
@Szymongib Thanks for your PR. First of all, this PR is enough valuable to merge. I think it would be better to add a unit test. WDYT? |
Signed-off-by: Szymon Gibała <szymongib@gmail.com>
Szymongib
force-pushed
the
fix/always-use-same-permissions
branch
from
46753a8
to
e085f42
Compare
|
Thanks, @utam0k. It is an interesting approach to mocking values for tests. I have added tests for the whole |
It seems the ci got failed 😭 Can you check it? |
.github/workflows/main.yml
Outdated
| @@ -64,7 +64,7 @@ jobs: | |||
| - run: sudo apt-get -y update | |||
| - run: sudo apt-get install -y pkg-config libsystemd-dev libdbus-glib-1-dev libelf-dev libseccomp-dev | |||
| - name: Run tests | |||
| run: cargo test --all --all-features --no-fail-fast | |||
| run: sudo cargo test --all --all-features --no-fail-fast | |||
There was a problem hiding this comment.
Sorry that was my attempt to fix it. The issue is that CI tests do not run as a root, therefore rootless_required always returns true.
There was a problem hiding this comment.
This, unfortunately, does not work, so I will try to find a way through it, otherwise, I will delete the test_determine_root_path_non_rootless test.
Szymongib
force-pushed
the
fix/always-use-same-permissions
branch
from
f57b1ef
to
52e8c0b
Compare
Signed-off-by: Szymon Gibała <szymongib@gmail.com>
Szymongib
force-pushed
the
fix/always-use-same-permissions
branch
from
52e8c0b
to
9af52a3
Compare
Signed-off-by: Szymon Gibała <szymongib@gmail.com>
|
Hey @utam0k, sorry for the inconvenience 😕 . I did not find a way to run tests as a root user so I added a check to skip the test if the user is not root https://github.com/containers/youki/pull/705/files#diff-6628fb893f86fbbacb0317d2125dc7777897c6eefac88ba293fb7e49bee75726R216-R219. Not sure if this is the best approach, let me know if you would prefer me to delete this test altogether. |
Summary
This PR aligns permissions of
/run/youkidirectory to700.Relevant line in runc https://github.com/opencontainers/runc/blob/main/libcontainer/factory_linux.go#L49
Fixes #481