Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching of OCI tests in CI #727

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Feb 21, 2022

This removes caching of OCI tests in CI. This is regarding to #721 , and should work as a temporary solution to it. This will increase the CI time, but will always use the latest commit version. There might be some work-around such that we can cache and invalidate cache when new commits are added to OCi repo, but this does not address it, it can be done in a separate PR.

@YJDoc2 YJDoc2 requested a review from utam0k February 21, 2022 11:49
@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Feb 21, 2022

@utam0k This should potentially solve #721 for now. This might result in slightly bad CI times (integration tests needing 5-7 mins) but that is preferable than having broken/outdated integration tests
Please take a look :)

}
_ => caps::drop(None, CapSet::Bounding, *c)?,
}
caps::drop(None, CapSet::Bounding, *c)?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but I'd like to consider checking the linux version

@utam0k
Copy link
Member

utam0k commented Feb 23, 2022

@YJDoc2 Thanks for your hard work!!! 💯

@utam0k utam0k merged commit 673d2e1 into youki-dev:main Feb 23, 2022
@YJDoc2 YJDoc2 deleted the oci-test-fix branch October 7, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants