Add support for seccomp filter flags #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 72.52% 72.43% -0.10%
==========================================
Files 86 86
Lines 11740 11763 +23
==========================================
+ Hits 8515 8520 +5
- Misses 3225 3243 +18 |
harche
reviewed
Feb 23, 2022
saschagrunert
force-pushed
the
filter-flag-log
branch
from
2cf3324
to
d782749
Compare
saschagrunert
added a commit
to saschagrunert/common
that referenced
this pull request
Feb 23, 2022
crun supports seccomp filter flags since containers/crun@fefabff runc will get them with opencontainers/runc#3390 youki will get them with youki-dev/youki#733 To support them generally, we now copy the flags during the seccomp setup, otherwise they will get lost. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Container runtimes like `crun` already support the flags: containers/crun@fefabff We now support the flags `SECCOMP_FILTER_FLAG_SPEC_ALLOW`, `SECCOMP_FILTER_FLAG_TSYNC` as well as `SECCOMP_FILTER_FLAG_LOG` and refactor the flag code into the filter context. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
filter-flag-log
branch
from
d782749
to
d837153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container runtimes like
crunalready support the flags: containers/crun@fefabffWe now support the flags
SECCOMP_FILTER_FLAG_SPEC_ALLOW,SECCOMP_FILTER_FLAG_TSYNCas well asSECCOMP_FILTER_FLAG_LOGand refactor the flag code into the filter context.