Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oci-spec-rs to v0.5.5 #744

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

saschagrunert
Copy link
Collaborator

@saschagrunert saschagrunert commented Feb 28, 2022

This means we can now use the filter types to enforce tighter type checks.

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@saschagrunert saschagrunert force-pushed the oci-spec-update branch 9 times, most recently from db36e0f to 2b476a6 Compare February 28, 2022 13:57
@saschagrunert
Copy link
Collaborator Author

Hm, I'm wondering why the integration tests now fail 🤔

@utam0k
Copy link
Member

utam0k commented Mar 2, 2022

@saschagrunert I did a little exploring on my end. It seems that youki's original integration test is failing from this PR. I'll try to find out what it is a little more, but I don't have time today, so it will be next Saturday and Sunday.
#740

@utam0k
Copy link
Member

utam0k commented Mar 6, 2022

@saschagrunert Can I ask you to rebase?

This means we can now use the filter types to enforce tighter type
checks.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Collaborator Author

Rebased on top of main.

@utam0k
Copy link
Member

utam0k commented Mar 7, 2022

@saschagrunert Thanks. LGTM

@utam0k utam0k merged commit 6d6a7c0 into youki-dev:main Mar 7, 2022
@saschagrunert saschagrunert deleted the oci-spec-update branch March 7, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants