Use close_range where possible #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Furisto <24721048+Furisto@users.noreply.github.com>
Signed-off-by: Furisto <24721048+Furisto@users.noreply.github.com>
Signed-off-by: Furisto <24721048+Furisto@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #758 +/- ##
==========================================
- Coverage 72.24% 72.22% -0.02%
==========================================
Files 86 86
Lines 11756 11792 +36
==========================================
+ Hits 8493 8517 +24
- Misses 3263 3275 +12 |
Signed-off-by: Furisto <24721048+Furisto@users.noreply.github.com>
|
@YJDoc2 Done |
utam0k
reviewed
Mar 7, 2022
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
utam0k
reviewed
Mar 7, 2022
Comment on lines
+341
to
+343
| syscall | ||
| .close_range(preserve_fds) | ||
| .with_context(|| "failed to clean up extra fds")?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the close_range system call to close file descriptors when creating the container. This supersedes our userspace implementation of this feature for kernels >=5.11. Close_range has better performance and does not require a mounted procfs.
More info