-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve deprecation warnings from clap #798
Resolve deprecation warnings from clap #798
Conversation
NOTE : The lint CI is failing due to these two only. This does not resolve all the deprecation warnings, there are two which still remain :
Issue with resolving these, is that in the clap docs, both of them only have documentation for builder API, not the derive API which we use for youki. Thus in worst case, two subcommands which use these two might need to be refactored and ported to use the builder API instead of derive, and might also require some additional checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets raise an issue with clap for the missing derive support and silence the warnings in the meanwhile.
I spent some time seeing if there was any workaround, but didn't find any. I have opened a discussion at clap : clap-rs/clap#3584 Also we don't have to silence the warnings immediately, as the CI will check them only if files in crates/* are changed. If this gets resolved before such a change occurs, then we won't need to change the CI, else we can change it temporarily in the PR where this issue occurs. |
f5da54f
to
f02005f
Compare
f02005f
to
167bf29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
This resolves some of the clap deprecation warnings. This is part of resolving #771 .