Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenient use of rust-analyzer and other tools by placing Cargo.toml in the root. #855

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Apr 19, 2022

Convenient use of rust-analyzer and other tools by placing Cargo.toml in the root.

@utam0k utam0k marked this pull request as draft April 20, 2022 12:20
@utam0k utam0k force-pushed the root-cargo-toml branch 3 times, most recently from 3c7d7eb to dd726e8 Compare April 22, 2022 12:53
@utam0k utam0k marked this pull request as ready for review April 22, 2022 13:04
@utam0k utam0k requested review from YJDoc2 and Furisto April 22, 2022 13:04
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Apr 24, 2022

This seems to work fine, and now rust analyzer works with the nested crates 👍
There are couple of conflicts in lock files, probably due to other merged PRs.
@Furisto if possible, can you take a look on this as well? Thanks.

@utam0k
Copy link
Member Author

utam0k commented Apr 24, 2022

I've fixed the conflict.

@Furisto
Copy link
Collaborator

Furisto commented Apr 25, 2022

This seems to work fine, and now rust analyzer works with the nested crates +1 There are couple of conflicts in lock files, probably due to other merged PRs. @Furisto if possible, can you take a look on this as well? Thanks.

Yes, will take a look at this at the end of today.

… in the root.

Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k utam0k merged commit f60f4fc into youki-dev:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants