support configure cpu.idle by Cgroupfs #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
reviewed
May 9, 2022
| @@ -29,7 +29,7 @@ libc = "0.2.125" | |||
| log = "0.4" | |||
| mio = { version = "0.8.3", features = ["os-ext", "os-poll"] } | |||
| nix = "0.24.1" | |||
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "89376af" } | |||
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "6df620e" } | |||
There was a problem hiding this comment.
Suggested change
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "6df620e" } | |
| oci-spec = "0.5.6" |
utam0k
reviewed
May 9, 2022
| @@ -25,7 +25,7 @@ libcontainer = { version = "0.0.3", path = "../libcontainer" } | |||
| liboci-cli = { version = "0.0.3", path = "../liboci-cli" } | |||
| log = { version = "0.4", features = ["std"]} | |||
| nix = "0.24.1" | |||
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "89376af" } | |||
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "6df620e" } | |||
There was a problem hiding this comment.
Suggested change
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "6df620e" } | |
| oci-spec = "0.5.6" |
utam0k
reviewed
May 9, 2022
| @@ -43,7 +43,7 @@ wasmer = { version = "2.2.0", optional = true } | |||
| wasmer-wasi = { version = "2.2.0", optional = true } | |||
|
|
|||
| [dev-dependencies] | |||
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "89376af", features = ["proptests"] } | |||
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "6df620e", features = ["proptests"] } | |||
There was a problem hiding this comment.
Suggested change
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "6df620e", features = ["proptests"] } | |
| oci-spec = { version = "0.5.6", features = ["proptests"] } |
utam0k
reviewed
May 9, 2022
| @@ -25,7 +25,7 @@ nix = "0.24.1" | |||
| procfs = "0.12.0" | |||
| log = "0.4" | |||
| anyhow = "1.0" | |||
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "89376af" } | |||
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "6df620e" } | |||
There was a problem hiding this comment.
Suggested change
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "6df620e" } | |
| oci-spec = "0.5.6" |
utam0k
reviewed
May 9, 2022
| @@ -35,7 +35,7 @@ errno = { version = "0.2.8", optional = true } | |||
| libc = { version = "0.2.125", optional = true } | |||
|
|
|||
| [dev-dependencies] | |||
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "89376af", features = ["proptests"] } | |||
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "6df620e", features = ["proptests"] } | |||
There was a problem hiding this comment.
Suggested change
| oci-spec = { git = "https://github.com/containers/oci-spec-rs", rev = "6df620e", features = ["proptests"] } | |
| oci-spec = { version = "0.5.6", features = ["proptests"] } |
utam0k
reviewed
May 9, 2022
There was a problem hiding this comment.
@wineway Thanks for your first contribution. I left some comments. If you are okay, please add some integration tests? If you don't have time to add it, please tell me.
https://github.com/containers/youki/tree/main/tests/rust-integration-tests/integration_test/src/tests/cgroups/cpu
tsturzl
suggested changes
May 9, 2022
Signed-off-by: wineway <wangyuweihx@gmail.com>
Signed-off-by: wineway <wangyuweihx@gmail.com>
|
@utam0k @tsturzl updated! PTAL and seems tag |
Oops, sorry, I failed to include your PR when I released oci-spec-rs 😭 |
Signed-off-by: wineway <wangyuweihx@gmail.com>
|
@utam0k Can you help trigger ci again? I don't have a cgroupv1 env, and I would like to ensure integration test is correct😂 |
|
@tsturzl Can I ask you to review it again? |
tsturzl
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.