Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django19fix #501

Closed
wants to merge 1 commit into from
Closed

Django19fix #501

wants to merge 1 commit into from

Conversation

beltiras
Copy link

@beltiras beltiras commented Oct 2, 2015

No description provided.

@jonashaag
Copy link
Contributor

Note that patterns has not been removed in Django 1.9 but in Django 1.10, so this ticket should be called "Django110 fix".

@blueyed
Copy link
Member

blueyed commented Oct 3, 2015

@jonashaag
But there's a deprecation warning then that gets fixed with 1.9, right?

@arnists
Can you squash your commits into a single one, please?

@beltiras
Copy link
Author

beltiras commented Oct 6, 2015

I don't understand why the build fails. I just squashed the commits as asked to, changes are the same. Were any other commits accepted onto main with failing builds?

@jonashaag
Copy link
Contributor

Were any other commits accepted onto main with failing builds?

Nope, master build seems ok, but you could try by opening a pull request with an empty commit.

@blueyed
Copy link
Member

blueyed commented Oct 6, 2015

Tests failures seem to be caused by a bug in pytest-django: pytest-dev/pytest-django#280

blueyed added a commit that referenced this pull request Oct 6, 2015
@beltiras beltiras closed this Oct 6, 2015
@beltiras beltiras deleted the django19fix branch October 6, 2015 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants