Skip to content

Commit

Permalink
Revert "Prevent garbage collection of ScriptValue References."
Browse files Browse the repository at this point in the history
This reverts commit 4d314ec0e22e86c400c65e017b1a33e67ff8f23b.

Reason for revert: Suspecting cause of endurance test failures

Change-Id: Iec04dd48db117284acad356960ba6027aa0a88ca
NOKEYCHECK=True
GitOrigin-RevId: 53ff25c7520a0190d38a428ec218fcf9577fa297
  • Loading branch information
kaidokert authored and andrewsavage1 committed Feb 23, 2023
1 parent d39764a commit 680cb1d
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions cobalt/script/script_value.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,13 @@ class ScriptValue {
: owner_(wrappable), referenced_value_(script_value.MakeCopy()) {
DCHECK(!referenced_value_->IsNull());
referenced_value_->RegisterOwner(owner_);
referenced_value_->PreventGarbageCollection();
}

Reference(Wrappable* wrappable, const Handle<T>& local)
: owner_(wrappable),
referenced_value_(local.GetScriptValue()->MakeCopy()) {
DCHECK(!referenced_value_->IsNull());
referenced_value_->RegisterOwner(owner_);
referenced_value_->PreventGarbageCollection();
}

const T& value() const { return *(referenced_value_->GetValue()); }
Expand All @@ -91,10 +89,7 @@ class ScriptValue {
return *(referenced_value_.get());
}

~Reference() {
referenced_value_->AllowGarbageCollection();
referenced_value_->DeregisterOwner(owner_);
}
~Reference() { referenced_value_->DeregisterOwner(owner_); }

private:
Wrappable* const owner_;
Expand Down

0 comments on commit 680cb1d

Please sign in to comment.