Refresh cobalt_evergreen_overview.md for Cobalt 24 #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
- Coverage 56.54% 56.53% -0.01%
==========================================
Files 1899 1899
Lines 94144 94144
==========================================
- Hits 53237 53228 -9
- Misses 40907 40916 +9 |
alexanderahn
approved these changes
Aug 3, 2023
The changes are all to the build section and include: * Instructions for building crashpad_handler w/ native_target toolchain * Recommendation to use `gn gen` directly instead of the wrapper script * Instructions for setting Starboard version in build commands * Removal of gyp references b/270858365 Change-Id: I6a5270d9ce2afcc444637cf0be81300f38215da6
b/270858365 Change-Id: I5419405a0bfffc339c916c475dd9309ddbc5ea73
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
The changes are all to the build section and include: * Instructions for building crashpad_handler w/ native_target toolchain * Recommendation to use `gn gen` directly instead of the wrapper script * Instructions for setting Starboard version in build commands * Removal of gyp references b/270858365 Change-Id: I6a5270d9ce2afcc444637cf0be81300f38215da6 (cherry picked from commit 0da921a)
hlwarriner
added a commit
that referenced
this pull request
Aug 4, 2023
… 24 (#1148) Refer to the original PR: #1117 The changes are all to the build section and include: * Instructions for building crashpad_handler w/ native_target toolchain * Recommendation to use `gn gen` directly instead of the wrapper script * Instructions for setting Starboard version in build commands * Removal of gyp references b/270858365 Change-Id: I6a5270d9ce2afcc444637cf0be81300f38215da6 Co-authored-by: Holden Warriner <hwarriner@google.com>
hlwarriner
added a commit
to hlwarriner/cobalt
that referenced
this pull request
Nov 14, 2023
This a smaller change than youtube#1117 and mostly just cleans up old GYP references. b/62677273 Change-Id: Idc9e51463099babf77a92f9fb5c830f9def01084
hlwarriner
added a commit
that referenced
this pull request
Nov 14, 2023
This a smaller change than #1117 and mostly just cleans up old GYP references. b/62677273 Change-Id: Idc9e51463099babf77a92f9fb5c830f9def01084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are all to the build section and include:
gn gendirectly instead of the wrapper scriptb/270858365
Change-Id: I6a5270d9ce2afcc444637cf0be81300f38215da6