Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove audio write limit after video eos written #2103

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Remove audio write limit after video eos written #2103

merged 4 commits into from
Feb 5, 2024

Conversation

jasonzhangxx
Copy link
Contributor

b/309651931

@jasonzhangxx jasonzhangxx changed the title Remove audio write limit after eos received Remove audio write limit after video eos written Dec 21, 2023
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ae8d5e) 58.41% compared to head (3e31cc7) 58.50%.

❗ Current head 3e31cc7 differs from pull request most recent head b1a7d3e. Consider uploading reports for the commit b1a7d3e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2103      +/-   ##
==========================================
+ Coverage   58.41%   58.50%   +0.08%     
==========================================
  Files        1902     1903       +1     
  Lines       94718    94555     -163     
==========================================
- Hits        55332    55321      -11     
+ Misses      39386    39234     -152

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonzhangxx jasonzhangxx enabled auto-merge (squash) February 5, 2024 21:44
@jasonzhangxx jasonzhangxx merged commit affed7a into youtube:main Feb 5, 2024
338 of 339 checks passed
@jasonzhangxx jasonzhangxx added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Mar 4, 2024
@jasonzhangxx jasonzhangxx deleted the write-duration-eos branch March 4, 2024 18:44
cobalt-github-releaser-bot pushed a commit that referenced this pull request Mar 4, 2024
@jasonzhangxx @anonymous1-me
Remove audio write limit after video eos written (#2103)
de12466 
b/309651931

(cherry picked from commit affed7a)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Mar 4, 2024
Merged
jasonzhangxx added a commit that referenced this pull request Mar 19, 2024
@cobalt-github-releaser-bot @jasonzhangxx
Cherry pick PR #2103: Remove audio write limit after video eos written (
148d5d1 
#2537)

Refer to the original PR: #2103

b/309651931

---------

Co-authored-by: Jason <jasonzh@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaomings xiaomings xiaomings approved these changes

Assignees
No one assigned
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonzhangxx @xiaomings