Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XB1] Cap framerate at 60fps for 4k HDR videos #2551

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

TyHolc
Copy link
Contributor

@TyHolc TyHolc commented Mar 6, 2024

Adding more constraints when choosing display mode to avoid requesting modes that exceed videos we serve.

b/324130696

Change-Id: I103b48a0d33369c910acb3d1d32809f442cd49ff

Adding more constraints when choosing display mode to avoid requesting
modes that exceed videos we serve.

b/324130696

Change-Id: I103b48a0d33369c910acb3d1d32809f442cd49ff
@TyHolc TyHolc requested a review from jasonzhangxx March 6, 2024 23:05
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.21%. Comparing base (b8ff539) to head (38fafe5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2551   +/-   ##
=======================================
  Coverage   58.20%   58.21%           
=======================================
  Files        1788     1788           
  Lines       84248    84248           
=======================================
+ Hits        49036    49044    +8     
+ Misses      35212    35204    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TyHolc TyHolc merged commit 5619513 into youtube:main Mar 14, 2024
340 of 341 checks passed
@TyHolc TyHolc deleted the cap-4k-framerate branch March 14, 2024 18:22
@TyHolc TyHolc added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Mar 14, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Mar 14, 2024
Adding more constraints when choosing display mode to avoid requesting
modes that exceed videos we serve.

b/324130696

Change-Id: I103b48a0d33369c910acb3d1d32809f442cd49ff
(cherry picked from commit 5619513)
TyHolc added a commit that referenced this pull request Mar 18, 2024
…2600)

Refer to the original PR: #2551

Adding more constraints when choosing display mode to avoid requesting
modes that exceed videos we serve.

b/324130696

Change-Id: I103b48a0d33369c910acb3d1d32809f442cd49ff

Co-authored-by: Tyler Holcombe <tholcombe@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants